Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle folders which look like elemetns but aren't #1073

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

wynged
Copy link
Member

@wynged wynged commented Dec 12, 2023

BACKGROUND:

  • De-serializing folders in tests broke recently because we started falling back to elements if something has an "Id" property, which folders do, but they are not Elements

DESCRIPTION:

  • Check if there is a discriminator before falling back to Element or GeometricElement. non-elements can't fallback to these types even if they have an Id or Representation property.

TESTING:

  • try to make/run a function that as a folder as an input. You will get a de serialization error on de serializing the input, then try with this change.

FUTURE WORK:

  • NA

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

Copy link
Contributor

@anthonie-kramer anthonie-kramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit 001c0f6 into master Dec 12, 2023
2 checks passed
@wynged wynged deleted the handle-deserialize-folders branch December 12, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants